LC has duplicate conditions leading to untestable branches

[skliper]

LC_ValidateWDT has duplicate conditions in its switch statement for both DataType and OperatorID. This leads to branches that cannot be covered by unit testing.

Imported from GSFCCFS-1731

EDIT:
Duplicate conditional in PUSH_RPN_DATA, since the limit is checked before the push and can never be exceeded

LC/fsw/src/lc_action.c

Line 298 in bb91036

#define PUSH_RPN_DATA(x) ((StackPtr >= LC_MAX_RPN_EQU_SIZE) ? (IllegalRPN = true) : (RPNStack[StackPtr++] = x))

Setting Done to true when IllegalOperand is true makes the checks redundant

LC/fsw/src/lc_action.c

Lines 416 to 423 in bb91036

	if ((EvalResult == LC_WATCH_ERROR) || (EvalResult == LC_WATCH_STALE))
	{
	IllegalOperand = true;
	}
	if (StackPtr == 0)
	{
	Done = true;
	}

LC/fsw/src/lc_action.c

Line 450 in bb91036

if ((Done == false) && (IllegalRPN == false) && (IllegalOperand == false))

LC/fsw/src/lc_action.c

Line 321 in bb91036

while ((Done == false) && (IllegalRPN == false) && (IllegalOperand == false))

Recommended resolutions:
Remove duplicate condions in LC_ValidateWDT, replace PUSH_RPN_DATA with simple push, don't set Done when IllegalOperand.