Merge pull request #27 from skliper/fix26-static_analysis_style

Fix #26, Resolve strict cppcheck style warnings
nasa · May 11, 2022 · 8759384 · 8759384
2 parents 64b4f8d + efeb5ba
commit 8759384
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 9 deletions.
diff --git a/fsw/src/lc_cmds.h b/fsw/src/lc_cmds.h
@@ -77,13 +77,13 @@ void LC_ResetCounters(void);
  *  \par Assumptions, External Events, and Notes:
  *       None
  *
- *  \param [in]   StartIndex   Start of area to reset (base zero)
- *  \param [in]   EndIndex     End of area to reset (base zero)
- *  \param [in]   ResetCmd     Reset AP stats command does not reset all fields
+ *  \param [in]   StartIndex    Start of area to reset (base zero)
+ *  \param [in]   EndIndex      End of area to reset (base zero)
+ *  \param [in]   ResetStatsCmd Reset AP stats command does not reset all fields
  *
  *  \sa #LC_ResetAPStatsCmd
  */
-void LC_ResetResultsAP(uint32 StartIndex, uint32 EndIndex, bool ResetCmd);
+void LC_ResetResultsAP(uint32 StartIndex, uint32 EndIndex, bool ResetStatsCmd);
 
 /**
  * \brief Reset WP results
@@ -94,13 +94,13 @@ void LC_ResetResultsAP(uint32 StartIndex, uint32 EndIndex, bool ResetCmd);
  *  \par Assumptions, External Events, and Notes:
  *       None
  *
- *  \param [in]   StartIndex   Start of area to reset (base zero)
- *  \param [in]   EndIndex     End of area to reset (base zero)
- *  \param [in]   ResetCmd     Reset WP stats command does not reset all fields
+ *  \param [in]   StartIndex    Start of area to reset (base zero)
+ *  \param [in]   EndIndex      End of area to reset (base zero)
+ *  \param [in]   ResetStatsCmd Reset WP stats command does not reset all fields
  *
  *  \sa #LC_ResetWPStatsCmd
  */
-void LC_ResetResultsWP(uint32 StartIndex, uint32 EndIndex, bool ResetCmd);
+void LC_ResetResultsWP(uint32 StartIndex, uint32 EndIndex, bool ResetStatsCmd);
 
 /**
  * \brief Sample actionpoints request

diff --git a/fsw/src/lc_utils.c b/fsw/src/lc_utils.c
@@ -231,7 +231,7 @@ int32 LC_UpdateTaskCDS(void)
 
 int32 LC_PerformMaintenance(void)
 {
-    int32 Result = CFE_SUCCESS;
+    int32 Result;
 
     /*
     ** Manage tables - allow cFE to perform dump, update, etc.