Fix #114, clean up dispatch logic #115
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -46,7 +46,7 @@ | |||
| /* Housekeeping request */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| void HS_SendHkCmd(const CFE_SB_Buffer_t *BufPtr) | |||
| CFE_Status_t HS_SendHkCmd(const HS_SendHkCmd_t *BufPtr) | |||
Check notice
Code scanning / CodeQL
Function too long Note
| } | ||
|
|
||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| /* */ | ||
| /* Disable event monitor command */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void HS_DisableEventMonCmd(const CFE_SB_Buffer_t *BufPtr) | ||
| CFE_Status_t HS_DisableEventMonCmd(const HS_DisableEventMonCmd_t *BufPtr) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| } | ||
|
|
||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| /* */ | ||
| /* Enable events monitor command */ | ||
| /* */ | ||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | ||
| void HS_EnableEventMonCmd(const CFE_SB_Buffer_t *BufPtr) | ||
| CFE_Status_t HS_EnableEventMonCmd(const HS_EnableEventMonCmd_t *BufPtr) |
Check notice
Code scanning / CodeQL
Long function without assertion Note
| @@ -46,7 +46,7 @@ | |||
| /* Housekeeping request */ | |||
| /* */ | |||
| /* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */ | |||
| void HS_SendHkCmd(const CFE_SB_Buffer_t *BufPtr) | |||
| CFE_Status_t HS_SendHkCmd(const HS_SendHkCmd_t *BufPtr) | |||
Check notice
Code scanning / CodeQL
Long function without assertion Note
Next step in adherence to established patterns for headers and dispatch code. - Define MsgIDs for HS based on TopicIDs - Define Command Handlers based on pattern (CFE_Status_t return, command structure type input) - Define EDS dispatcher
jphickey
force-pushed
the
fix-114-topicids
branch
from
bcab408
to
2cadd38
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Next step in adherence to established patterns for headers and dispatch code.
Fixes #114
Testing performed
Build and run
Expected behavior changes
None
System(s) tested on
Debian
Additional context
Dispatch logic now has topicID-based definitions and fully supports EDS definitions via the eds_dispatch code.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.