Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Possible incorrect reference to HS_AMT_ACT_LAST_NONMSG #121

Closed
LucienMorey opened this issue Feb 12, 2024 · 0 comments · Fixed by #122
Closed

Possible incorrect reference to HS_AMT_ACT_LAST_NONMSG #121

LucienMorey opened this issue Feb 12, 2024 · 0 comments · Fixed by #122
Labels
bug

Comments

@LucienMorey
Copy link
Contributor

LucienMorey commented Feb 12, 2024 •
edited
Loading

https://github.com/nasa/HS/blob/f92bec8bfb599925c31b6af501dcd4e7a73c524b/fsw/src/hs_monitors.c#L329C53-L329C75

I could be wrong but I think this line should use HS_EMT_ACT_LAST_NONMSG instead of HS_AMT_ACT_LAST_NONMSG since this is the event monitoring handler. I think it works in a default configuration because they have the same value.
@LucienMorey LucienMorey mentioned this issue Feb 12, 2024
Merged
2 tasks
@dmknutsen dmknutsen added the bug label Feb 22, 2024
dzbaker added a commit that referenced this issue Feb 22, 2024
@dzbaker
Merge pull request #122 from LucienMorey/LucienMorey/fix-121-incorrec…
728f432 
…t-macro-usage

Fix #121, fix incorrect macro usage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #121, fix incorrect macro usage LucienMorey/HS
2 participants
@LucienMorey @dmknutsen