Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

HS should use CFE_TBL_FILEDEF macro #113

Closed
2 tasks done
jphickey opened this issue Dec 18, 2023 · 0 comments · Fixed by #118
Closed
2 tasks done

HS should use CFE_TBL_FILEDEF macro #113

jphickey opened this issue Dec 18, 2023 · 0 comments · Fixed by #118

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
HS Table definitions should use the CFE_TBL_FILEDEF macro. They should not directly instantiate the CFE_TBL_FileDef_t object.

To Reproduce
N/A

Expected behavior
Use the CFE_TBL_FILEDEF macro.

System observed on:
Debian

Additional context
The intent of the CFE_TBL_FILEDEF macro is to allow the definition/interpretation of the CFE_TBL_FileDef_t structure to evolve depending on the table generation tool. Directly instantiating the object only works with the current definition.

Reporter Info
Joseph Hickey, Vantage Systems, Inc.
jphickey added a commit to jphickey/HS that referenced this issue Jan 17, 2024
@jphickey
Fix nasa#113, use CFE_TBL_FILEDEF macro for table definitions
6156601 
The FILEDEF macro is intended to allow table source files to adapt to other
tools and workflows more easily.  The macro should be used instead of
instantiating the CFE_TBL_FileDef_t structure directly.
@jphickey jphickey mentioned this issue Jan 17, 2024
Merged
2 tasks
dzbaker added a commit that referenced this issue Jan 18, 2024
@dzbaker
Merge pull request #118 from jphickey/fix-113-tbl-filedef
e609be9 
Fix #113, use CFE_TBL_FILEDEF macro for table definitions
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #113, use CFE_TBL_FILEDEF macro for table definitions jphickey/HS
1 participant
@jphickey