Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove UT TODOs and clean up related tests #18

Closed
3 tasks done
skliper opened this issue Jul 29, 2022 · 0 comments · Fixed by #20
Closed
3 tasks done

Remove UT TODOs and clean up related tests #18

skliper opened this issue Jul 29, 2022 · 0 comments · Fixed by #20
Assignees
Milestone

Comments

@skliper
Copy link
Contributor

skliper commented Jul 29, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.

HK/unit-test/hk_app_tests.c

Lines 1192 to 1208 in fbb231e

void Test_HK_SendCombinedHKCmd(void)
{
/* Arrange */
CFE_SB_Buffer_t DummyBuf;
uint8 call_count_HK_SendCombinedHkPacket;
/* TODO set return value of CFE_SB_GetUserData and check input to
HK_SendCombinedHkPacket */
/* Act */
HK_SendCombinedHKCmd(&DummyBuf);
call_count_HK_SendCombinedHkPacket = UT_GetStubCount(UT_KEY(HK_SendCombinedHkPacket));
/* Assert */
UtAssert_INT32_EQ(call_count_HK_SendCombinedHkPacket, 1);
}

Describe the solution you'd like
Remove TODO and clean

Describe alternatives you've considered
None

Additional context
None

Requester Info
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the Draco milestone Jul 29, 2022
@skliper skliper self-assigned this Jul 29, 2022
skliper added a commit to skliper/HK that referenced this issue Jul 29, 2022
@dzbaker dzbaker closed this as completed in 82ce320 Aug 3, 2022
dzbaker added a commit that referenced this issue Aug 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants