Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #36, Remove redundant conditional to support full coverage #38

Merged
merged 1 commit into from
Jun 22, 2022

Conversation

skliper
Copy link
Contributor

@skliper skliper commented Jun 15, 2022

Checklist (Please check before submitting)

Describe the contribution

Removes the redundant length check.

Testing performed
CI

Expected behavior changes
None, the element sizes are already sufficient to fit... can't fail check without overflowing local variables.

System(s) tested on
CI

Additional context
None

Third party code
None

Contributor Info - All information REQUIRED for consideration of pull request
Jacob Hageman - NASA/GSFC

@skliper skliper added this to the Draco milestone Jun 15, 2022
@skliper skliper assigned skliper and chillfig and unassigned skliper Jun 15, 2022
@astrogeco
Copy link
Contributor

CCB:2022.06.22 APPROVED

@astrogeco astrogeco merged commit d2bffb4 into nasa:main Jun 22, 2022
@skliper skliper deleted the fix36-redundant_length_check branch September 19, 2022 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

fm_child.c has an unreachable branch
3 participants