Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use CFE pattern for command handler functions #95

Open
3 tasks done
jphickey opened this issue Mar 17, 2023 · 0 comments · May be fixed by #96
Open
3 tasks done

Use CFE pattern for command handler functions #95

jphickey opened this issue Mar 17, 2023 · 0 comments · May be fixed by #96

Comments

@jphickey
Copy link
Contributor

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
CFE has an established pattern for message dispatch routines in that:

  1. It returns a CFE_Status_t (standard return value)
  2. It accepts a single argument which is a const pointer to the message, of the actual/unique message type (e.g. CFE_ES_NoopCmd_t, etc).

FM does not follow this pattern, its message processor functions return bool and they accept the generic CFE SB message buffer rather than the specific message type.

Describe the solution you'd like
Make FM follow the CFE pattern

Additional context
This makes every command handler prototype unique, so they cannot be inadvertently interchanged without a compile error (this is a good thing).

Requester Info
Joseph Hickey, Vantage Systems, Inc.

thnkslprpt added a commit to thnkslprpt/FM that referenced this issue Apr 5, 2023
jphickey added a commit to jphickey/FM that referenced this issue Apr 28, 2023
Adhere to the message dispatch pattern used by CFE and framework apps
jphickey added a commit to jphickey/FM that referenced this issue Apr 28, 2023
Adhere to the message dispatch pattern used by CFE and framework apps
thnkslprpt added a commit to thnkslprpt/FM that referenced this issue May 19, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants