Fix #85, updates to struct/typedef names #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Implements a bit of paradigm shift in how names of symbols/types are generated, relying on prefixes rather than suffixes. Using suffixes has an opportunity of name collisions that is not possible when using prefixes. A separate typedef file maps to the existing type names and thus keeps it compatible with existing code, but only if that typedef file is used.
jphickey
force-pushed
the
fix-85-structdefs
branch
from
903a442
to
147dc08
Compare
dzbaker
added
CCB:Provisionally-Approved
and removed
CCB:Ready
dzbaker
added
CCB:Approved
This was referenced Mar 6, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the contribution
Implements a bit of paradigm shift in how names of symbols/types are generated, relying on prefixes rather than suffixes. Using suffixes has an opportunity of name collisions that is not possible when using prefixes.
A separate typedef file maps to the existing type names and thus keeps it compatible with existing code, but only if that typedef file is used.
Fixes #85
Testing performed
Build CFE with EDS and sanity check
Expected behavior changes
The generated type names are (intentionally) all different and unique from the names used in CFE. An extra layer of typedef is used to connect the CFE data types to EDS generated types.
System(s) tested on
Debian
Additional context
The previous model of making the EDS scripts generate type names that exactly match what the CFE code references was getting unsustainable, as there are too many small variations in the code, particularly as more of the CFS apps got EDS-ified. This is only stable if the code is only/always built with EDS-generated headers.
The intent here is that by adding an extra layer of typedefs between them, this can better adapt to mixtures of EDS and non-EDS environments.
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.