Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #107, Convert command success events to INFORMATION type #110

Merged
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion fsw/inc/ds_events.h
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@
/**
* \brief DS Application Enable/Disable State Command Event ID
*
* \par Type: DEBUG
* \par Type: INFORMATION
*
* \par Cause:
*
Expand Down
32 changes: 16 additions & 16 deletions fsw/inc/ds_msgdefs.h
Original file line number Diff line number Diff line change
Expand Up @@ -98,7 +98,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_ENADIS_CMD_EID debug event message will be sent
* - The #DS_ENADIS_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -127,7 +127,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_FILE_CMD_EID debug event message will be sent
* - The #DS_FILE_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -160,7 +160,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_FTYPE_CMD_EID debug event message will be sent
* - The #DS_FTYPE_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -193,7 +193,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_PARMS_CMD_EID debug event message will be sent
* - The #DS_PARMS_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -226,7 +226,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_NTYPE_CMD_EID debug event message will be sent
* - The #DS_NTYPE_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -257,7 +257,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_STATE_CMD_EID debug event message will be sent
* - The #DS_STATE_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -288,7 +288,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_PATH_CMD_EID debug event message will be sent
* - The #DS_PATH_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -319,7 +319,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_BASE_CMD_EID debug event message will be sent
* - The #DS_BASE_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -350,7 +350,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_EXT_CMD_EID debug event message will be sent
* - The #DS_EXT_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -381,7 +381,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_SIZE_CMD_EID debug event message will be sent
* - The #DS_SIZE_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -412,7 +412,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_AGE_CMD_EID debug event message will be sent
* - The #DS_AGE_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -443,7 +443,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_SEQ_CMD_EID debug event message will be sent
* - The #DS_SEQ_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -473,7 +473,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_CLOSE_CMD_EID debug event message will be sent
* - The #DS_CLOSE_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -530,7 +530,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_ADD_MID_CMD_EID debug event message will be sent
* - The #DS_ADD_MID_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -563,7 +563,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_CLOSE_ALL_CMD_EID debug event message will be sent
* - The #DS_CLOSE_ALL_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down Expand Up @@ -592,7 +592,7 @@
* \par Command Verification
* Evidence of success may be found in the following telemetry:
* - #DS_HkTlm_Payload_t.CmdAcceptedCounter will increment
* - The #DS_REMOVE_MID_CMD_EID debug event message will be sent
* - The #DS_REMOVE_MID_CMD_EID informational event message will be sent
*
* \par Error Conditions
* This command can fail for the following reasons:
Expand Down
34 changes: 17 additions & 17 deletions fsw/src/ds_cmds.c
Original file line number Diff line number Diff line change
Expand Up @@ -142,7 +142,7 @@ void DS_SetAppStateCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_ENADIS_CMD_EID, CFE_EVS_EventType_DEBUG, "APP STATE command: state = %d",
CFE_EVS_SendEvent(DS_ENADIS_CMD_EID, CFE_EVS_EventType_INFORMATION, "APP STATE command: state = %d",
DS_AppStateCmd->EnableState);
}
}
Expand Down Expand Up @@ -240,7 +240,7 @@ void DS_SetFilterFileCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_FILE_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_FILE_CMD_EID, CFE_EVS_EventType_INFORMATION,
"FILTER FILE command: MID = 0x%08lX, index = %d, filter = %d, file = %d",
(unsigned long)CFE_SB_MsgIdToValue(DS_FilterFileCmd->MessageID), (int)FilterTableIndex,
DS_FilterFileCmd->FilterParmsIndex, DS_FilterFileCmd->FileTableIndex);
Expand Down Expand Up @@ -341,7 +341,7 @@ void DS_SetFilterTypeCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_FTYPE_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_FTYPE_CMD_EID, CFE_EVS_EventType_INFORMATION,
"FILTER TYPE command: MID = 0x%08lX, index = %d, filter = %d, type = %d",
(unsigned long)CFE_SB_MsgIdToValue(DS_FilterTypeCmd->MessageID), (int)FilterTableIndex,
DS_FilterTypeCmd->FilterParmsIndex, DS_FilterTypeCmd->FilterType);
Expand Down Expand Up @@ -446,7 +446,7 @@ void DS_SetFilterParmsCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_PARMS_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_PARMS_CMD_EID, CFE_EVS_EventType_INFORMATION,
"FILTER PARMS command: MID = 0x%08lX, index = %d, filter = %d, N = %d, X = %d, O = %d",
(unsigned long)CFE_SB_MsgIdToValue(DS_FilterParmsCmd->MessageID), (int)FilterTableIndex,
DS_FilterParmsCmd->FilterParmsIndex, pFilterParms->Algorithm_N, pFilterParms->Algorithm_X,
Expand Down Expand Up @@ -514,7 +514,7 @@ void DS_SetDestTypeCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_NTYPE_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_NTYPE_CMD_EID, CFE_EVS_EventType_INFORMATION,
"DEST TYPE command: file table index = %d, filename type = %d",
DS_DestTypeCmd->FileTableIndex, DS_DestTypeCmd->FileNameType);
}
Expand Down Expand Up @@ -577,7 +577,7 @@ void DS_SetDestStateCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_STATE_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_STATE_CMD_EID, CFE_EVS_EventType_INFORMATION,
"DEST STATE command: file table index = %d, file state = %d", DS_DestStateCmd->FileTableIndex,
DS_DestStateCmd->EnableState);
}
Expand Down Expand Up @@ -633,7 +633,7 @@ void DS_SetDestPathCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_PATH_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_PATH_CMD_EID, CFE_EVS_EventType_INFORMATION,
"DEST PATH command: file table index = %d, pathname = '%s'",
(int)DS_DestPathCmd->FileTableIndex, DS_DestPathCmd->Pathname);
}
Expand Down Expand Up @@ -688,7 +688,7 @@ void DS_SetDestBaseCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_BASE_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_BASE_CMD_EID, CFE_EVS_EventType_INFORMATION,
"DEST BASE command: file table index = %d, base filename = '%s'",
(int)DS_DestBaseCmd->FileTableIndex, DS_DestBaseCmd->Basename);
}
Expand Down Expand Up @@ -743,7 +743,7 @@ void DS_SetDestExtCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_EXT_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_EXT_CMD_EID, CFE_EVS_EventType_INFORMATION,
"DEST EXT command: file table index = %d, extension = '%s'",
(int)DS_DestExtCmd->FileTableIndex, DS_DestExtCmd->Extension);
}
Expand Down Expand Up @@ -807,7 +807,7 @@ void DS_SetDestSizeCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_SIZE_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_SIZE_CMD_EID, CFE_EVS_EventType_INFORMATION,
"DEST SIZE command: file table index = %d, size limit = %d",
(int)DS_DestSizeCmd->FileTableIndex, (int)DS_DestSizeCmd->MaxFileSize);
}
Expand Down Expand Up @@ -871,7 +871,7 @@ void DS_SetDestAgeCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_AGE_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_AGE_CMD_EID, CFE_EVS_EventType_INFORMATION,
"DEST AGE command: file table index = %d, age limit = %d", (int)DS_DestAgeCmd->FileTableIndex,
(int)DS_DestAgeCmd->MaxFileAge);
}
Expand Down Expand Up @@ -948,7 +948,7 @@ void DS_SetDestCountCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_SEQ_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_SEQ_CMD_EID, CFE_EVS_EventType_INFORMATION,
"DEST COUNT command: file table index = %d, sequence count = %d",
(int)DS_DestCountCmd->FileTableIndex, (int)DS_DestCountCmd->SequenceCount);
}
Expand Down Expand Up @@ -990,7 +990,7 @@ void DS_CloseFileCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_CLOSE_CMD_EID, CFE_EVS_EventType_DEBUG, "DEST CLOSE command: file table index = %d",
CFE_EVS_SendEvent(DS_CLOSE_CMD_EID, CFE_EVS_EventType_INFORMATION, "DEST CLOSE command: file table index = %d",
(int)DS_CloseFileCmd->FileTableIndex);
}
}
Expand Down Expand Up @@ -1019,7 +1019,7 @@ void DS_CloseAllCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_CLOSE_ALL_CMD_EID, CFE_EVS_EventType_DEBUG, "DEST CLOSE ALL command");
CFE_EVS_SendEvent(DS_CLOSE_ALL_CMD_EID, CFE_EVS_EventType_INFORMATION, "DEST CLOSE ALL command");
}

/* * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * * */
Expand All @@ -1039,7 +1039,7 @@ void DS_GetFileInfoCmd(const CFE_SB_Buffer_t *BufPtr)
*/
DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_GET_FILE_INFO_CMD_EID, CFE_EVS_EventType_DEBUG, "GET FILE INFO command");
CFE_EVS_SendEvent(DS_GET_FILE_INFO_CMD_EID, CFE_EVS_EventType_INFORMATION, "GET FILE INFO command");

/*
** Initialize file info telemetry packet...
Expand Down Expand Up @@ -1198,7 +1198,7 @@ void DS_AddMIDCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_ADD_MID_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_ADD_MID_CMD_EID, CFE_EVS_EventType_INFORMATION,
"ADD MID command: MID = 0x%08lX, filter index = %d, hash index = %d",
(unsigned long)CFE_SB_MsgIdToValue(DS_AddMidCmd->MessageID), (int)FilterTableIndex,
(int)HashTableIndex);
Expand Down Expand Up @@ -1292,7 +1292,7 @@ void DS_RemoveMIDCmd(const CFE_SB_Buffer_t *BufPtr)

DS_AppData.CmdAcceptedCounter++;

CFE_EVS_SendEvent(DS_REMOVE_MID_CMD_EID, CFE_EVS_EventType_DEBUG,
CFE_EVS_SendEvent(DS_REMOVE_MID_CMD_EID, CFE_EVS_EventType_INFORMATION,
"REMOVE MID command: MID = 0x%08lX, filter index = %d, hash index = %d",
(unsigned long)CFE_SB_MsgIdToValue(DS_RemoveMidCmd->MessageID), (int)FilterTableIndex,
(int)HashTableIndex);
Expand Down
Loading