Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sends an event message on failure of registering with EVS #85

Closed
2 tasks done
skliper opened this issue Mar 3, 2023 · 2 comments · Fixed by #86
Closed
2 tasks done

Sends an event message on failure of registering with EVS #85

skliper opened this issue Mar 3, 2023 · 2 comments · Fixed by #86

Comments

@skliper
Copy link
Contributor

skliper commented Mar 3, 2023

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
CFE_EVS_SendEvent is used when CFE_EVS_Register fails. Should use CFE_ES_WriteToSysLog for a better chance of actually recording the error.

Expected behavior
Use a mechanism for reporting errors that's more likely to succeed in case of an EVS registration failure.

Code snips

DS/fsw/src/ds_app.c

Lines 197 to 206 in 04c0154

/*
** Initialize interface to cFE Event Services...
*/
Result = CFE_EVS_Register(NULL, 0, 0);
if (Result != CFE_SUCCESS)
{
CFE_EVS_SendEvent(DS_INIT_ERR_EID, CFE_EVS_EventType_ERROR, "Unable to register for EVS services, err = 0x%08X",
(unsigned int)Result);
}

System observed on:
N/A

Additional context
Recommend checking the rest of the apps and marking as bug.

Reporter Info
Jacob Hageman - NASA/GSFC

@thnkslprpt
Copy link
Contributor

thnkslprpt commented Mar 3, 2023

DS and FM have this issue.
The rest already use CFE_ES_WriteToSysLog on failure of CFE_EVS_Register.

@thnkslprpt
Copy link
Contributor

Issue for FM: nasa/FM#87

dzbaker added a commit that referenced this issue Apr 6, 2023
…lure-to-WriteToSysLog

Fix #85, Change EVS_Register failure from SendEvent to WriteToSysLog
@dmknutsen dmknutsen added this to the Equuleus milestone May 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants