Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ammos GitHub 51: Support IV length being different from Transmitted Security Header IV Length #97

Merged
merged 8 commits into from
Apr 1, 2022

Conversation

IbraheemYSaleh
Copy link
Contributor

No description provided.

@codecov-commenter
Copy link

Codecov Report

Merging #97 (202ca3b) into dev (56e3865) will increase coverage by 0.62%.
The diff coverage is 98.50%.

@@            Coverage Diff             @@
##              dev      #97      +/-   ##
==========================================
+ Coverage   84.59%   85.22%   +0.62%     
==========================================
  Files          18       18              
  Lines        4954     5199     +245     
==========================================
+ Hits         4191     4431     +240     
- Misses        763      768       +5     
Impacted Files Coverage Δ
util/src_util/ut_crypto.c 100.00% <ø> (ø)
util/src_util/ut_kmc_crypto_with_mtls_sadb.c 0.00% <ø> (ø)
src/src_main/crypto_tc.c 88.47% <86.20%> (-0.71%) ⬇️
src/src_main/crypto.c 96.41% <100.00%> (+0.29%) ⬆️
src/src_main/crypto_config.c 95.58% <100.00%> (+0.01%) ⬆️
src/src_main/sadb_routine_inmemory.template.c 76.33% <100.00%> (+1.38%) ⬆️
util/src_util/et_dt_validation.c 98.93% <100.00%> (+<0.01%) ⬆️
util/src_util/ut_tc_apply.c 100.00% <100.00%> (ø)
util/src_util/ut_tc_process.c 100.00% <100.00%> (ø)
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 56e3865...202ca3b. Read the comment docs.

@IbraheemYSaleh
Copy link
Contributor Author

This feature was group programmed and, as such, reviewed during the programming session. Merging.

https://github.jpl.nasa.gov/ASEC/AMMOS-CryptoLib/issues/51
#95

@IbraheemYSaleh
Copy link
Contributor Author

@IbraheemYSaleh IbraheemYSaleh merged commit 509e074 into dev Apr 1, 2022
@dccutrig dccutrig linked an issue Apr 5, 2022 that may be closed by this pull request
@jlucas9 jlucas9 deleted the ammos-github-51 branch March 23, 2023 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Partial IV transmission
4 participants