Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

60 maturation of acs ecs #82

Merged
merged 7 commits into from
Mar 8, 2022
Merged

60 maturation of acs ecs #82

merged 7 commits into from
Mar 8, 2022

Conversation

dccutrig
Copy link
Contributor

@dccutrig dccutrig commented Mar 7, 2022

No description provided.

@dccutrig dccutrig linked an issue Mar 7, 2022 that may be closed by this pull request
Maturation of Acs/Ecs Enums #60
Closed
IbraheemYSaleh
IbraheemYSaleh suggested changes Mar 7, 2022
View reviewed changes
Copy link
Contributor

@IbraheemYSaleh IbraheemYSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This branch makes libgcrypt a core dependency -- that should not be the case and needs to properly isolate libgcrypt-isms to the libgcrypt cryptography interface implementation.

src/src_main/crypto.c Outdated Show resolved Hide resolved
include/crypto.h Outdated Show resolved Hide resolved
@dccutrig dccutrig self-assigned this Mar 8, 2022
@dccutrig dccutrig added the enhancement New feature or request label Mar 8, 2022
@dccutrig dccutrig requested a review from rjbrown2 March 8, 2022 20:18
@dccutrig dccutrig merged commit 492c3d0 into dev Mar 8, 2022
@jlucas9 jlucas9 deleted the 60-maturation-of-acs-ecs branch March 23, 2023 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbraheemYSaleh IbraheemYSaleh IbraheemYSaleh approved these changes

@rjbrown2 rjbrown2 Awaiting requested review from rjbrown2

Assignees

@dccutrig dccutrig

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Maturation of Acs/Ecs Enums
2 participants
@dccutrig @IbraheemYSaleh