69 rc1.0.3 #70
Merged
69 rc1.0.3 #70
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # util/CMakeLists.txt
Codecov Report
@@ Coverage Diff @@
## collab_main #70 +/- ##
===============================================
- Coverage 81.64% 81.62% -0.03%
===============================================
Files 17 17
Lines 3940 3941 +1
===============================================
Hits 3217 3217
- Misses 723 724 +1
Continue to review full report at Codecov.
|
| static int32_t sadb_get_operational_sa_from_gvcid(uint8_t, uint16_t, uint16_t, uint8_t, SecurityAssociation_t **); | ||
| static int32_t sadb_save_sa(SecurityAssociation_t *sa); | ||
| static int32_t sadb_get_sa_from_spi(uint16_t, SecurityAssociation_t* *); | ||
| static int32_t sadb_get_operational_sa_from_gvcid(uint8_t, uint16_t, uint16_t, uint8_t, SecurityAssociation_t* *); |
There was a problem hiding this comment.
SecurityAssociation_t** is better... The * * with the space concerns me -- probably works?
(the same * * thing happens in a number of places
IbraheemYSaleh
approved these changes
Feb 3, 2022
| @@ -81,7 +83,7 @@ int32_t Crypto_Key_OTAR(void) | |||
| } | |||
|
|
|||
| count = sdls_frame.pdu.pdu_len - MAC_SIZE; | |||
| for (int w = 0; w < 16; w++) | |||
| for (w = 0; w < 16; w++) | |||
There was a problem hiding this comment.
I disagree with pulling out the declaration like this 👎 ... works though /shrug.
dccutrig
approved these changes
Feb 3, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is this ready to roll?