AKMC-113: Add SADB Interfaces for MySQL/Inmemory configurability and basic implementation. #7
Conversation
…db & inmemory setups
…test SA creations cripts
| @@ -0,0 +1,36 @@ | |||
| CREATE DATABASE IF NOT EXISTS sadb; | |||
There was a problem hiding this comment.
Like the directory structure for the SADB / maria / SQL scripts. We were just talking this week about doing something like this to keep things separated for the different SA implementations.
fsw/public_inc/crypto_error.h
Outdated
| @@ -0,0 +1,23 @@ | |||
| /* Copyright (C) 2009 - 2017 National Aeronautics and Space Administration. All Foreign Rights are Reserved to the U.S. Government. | |||
There was a problem hiding this comment.
Note for us - we need to update copyrights and change the email address to the new mailing list.
| #ifdef NOS3 //NOS3/cFS build is ready | ||
| #include "common_types.h" | ||
| #include "osapi.h" | ||
| #else //Assume build outside of NOS3/cFS infrastructure |
There was a problem hiding this comment.
Good assumption that the build is outside nos3/cFS by default. We're still having discussions about how to ensure that we maintain the spacecraft build/functionality. Right now, we're leaning toward CryptoLib being a generic lib, and we will go back and adapt for spacecraft. (This is a role reversal for how CryptoLib was first designed.)
|
|
||
| #include "crypto_structs.h" | ||
|
|
||
| typedef struct { |
There was a problem hiding this comment.
Like this. Clean and straightforward.
|
Overall looked pretty good to me. Was able to pare down the diff that shows up on github with git diff --ignore-all-space akmc-113..collab_main -- fsw/src/crypto.c Excited for this merge and more progress |
| @@ -239,6 +251,39 @@ static int32 sadb_get_sa_from_spi(uint16 spi,SecurityAssociation_t** security_as | |||
| return status; | |||
| } | |||
|
|
|||
| static int32 sadb_get_operational_sa_from_gvcid(uint8 tfvn,uint16 scid,uint16 vcid,uint8 mapid,SecurityAssociation_t** security_association) | |||
There was a problem hiding this comment.
Nice, I like this and how it clears up the old SA stuff
|
Looks good - I like the direction the SA DB API is taking. |
No description provided.