CMAC Encryption/Decryption Added #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
dccutrig
commented
Jan 7, 2022
dccutrig
commented
- Added support CMAC enc/dec
- Added UTs for above
- Changed cipher/authentication suites to enums
- Some changes to SA Struct for pointers (ecs, abm)
…ge in checking field lengths now and ARC length now matters
dccutrig
requested review from
jlucas9,
IbraheemYSaleh,
rjbrown2 and
szemerick
Codecov Report
@@ Coverage Diff @@
## collab_main #52 +/- ##
===============================================
+ Coverage 60.76% 61.95% +1.19%
===============================================
Files 20 22 +2
Lines 3362 3746 +384
===============================================
+ Hits 2043 2321 +278
- Misses 1319 1425 +106
Continue to review full report at Codecov.
|
jlucas9
reviewed
Jan 7, 2022
| @@ -213,8 +220,9 @@ int32_t Crypto_TC_ApplySecurity(const uint8_t *p_in_frame, const uint16_t in_fra | |||
| case SA_AUTHENTICATION: | |||
| // Ingest length + spi_index (2) + shivf_len (varies) + shsnf_len (varies) | |||
| // + shplf_len + arc_len + pad_size + stmacf_len | |||
| // TODO: If ARC is transmitted in the SHSNF field (as in CMAC... don't double count those bytes) | |||
There was a problem hiding this comment.
Should make sure we create an issue for the couple of TODOs you've already identified
jlucas9
approved these changes
Jan 7, 2022
szemerick
reviewed
Jan 10, 2022
| } | ||
|
|
||
| // Need to copy the data over, since authentication won't change/move the data directly | ||
| memcpy(data_out, data_in, len_data_in); |
There was a problem hiding this comment.
Sanity check on the data_out ptr to ensure it's not NULL prior to use?
szemerick
reviewed
Jan 10, 2022
| } | ||
|
|
||
| // Need to copy the data over, since authentication won't change/move the data directly | ||
| memcpy(data_out, data_in, len_data_in); |
szemerick
reviewed
Jan 10, 2022
| @@ -68,8 +68,8 @@ typedef struct | |||
| uint8_t shsnf_len : 6; // Sec. Header SN Field Length | |||
| uint8_t shplf_len : 2; // Sec. Header PL Field Length | |||
| uint8_t stmacf_len : 8; // Sec. Trailer MAC Field Length | |||
| uint8_t *ecs; // Encryption Cipher Suite (algorithm / mode ID) | |||
There was a problem hiding this comment.
initialize pointers to NULL when applicable
szemerick
approved these changes
Jan 10, 2022
IbraheemYSaleh
approved these changes
Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.