Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

27 klockwork cleanup #45

Merged
merged 2 commits into from
Jan 3, 2022
Merged

27 klockwork cleanup #45

merged 2 commits into from
Jan 3, 2022

Conversation

szemerick
Copy link
Contributor

Issue #27 - See description here: #27

@szemerick szemerick self-assigned this Jan 3, 2022
jlucas9
jlucas9 approved these changes Jan 3, 2022
View reviewed changes
Copy link
Collaborator

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Definitely needed those checks and initializers.

@jlucas9 jlucas9 merged commit f8e9010 into collab_main Jan 3, 2022
@rjbrown2 rjbrown2 deleted the 27-klockwork-cleanup branch January 13, 2022 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlucas9 jlucas9 jlucas9 approved these changes

@IbraheemYSaleh IbraheemYSaleh IbraheemYSaleh approved these changes

@dccutrig dccutrig dccutrig approved these changes

@rjbrown2 rjbrown2 Awaiting requested review from rjbrown2

Assignees

@szemerick szemerick

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@szemerick @jlucas9 @IbraheemYSaleh @dccutrig