Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/cryptolib#347] Check crypto_config status before freeing #348

Merged

Conversation

Donnie-Ice
Copy link
Contributor

No description provided.

@Donnie-Ice Donnie-Ice self-assigned this Nov 7, 2024
@Donnie-Ice Donnie-Ice linked an issue Nov 7, 2024 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 8.33333% with 33 lines in your changes missing coverage. Please review.

Project coverage is 83.09%. Comparing base (a3f2e78) to head (f35d5db).
Report is 25 commits behind head on dev.

Files with missing lines Patch % Lines
src/core/crypto_config.c 8.33% 30 Missing and 3 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #348      +/-   ##
==========================================
- Coverage   84.04%   83.09%   -0.96%     
==========================================
  Files          83       81       -2     
  Lines       23507    20399    -3108     
  Branches     1783     1705      -78     
==========================================
- Hits        19757    16950    -2807     
+ Misses       3075     2772     -303     
- Partials      675      677       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@dccutrig dccutrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, seems to fix the issue.

@Donnie-Ice
Copy link
Contributor Author

I should note that this is using Hayk's (JPL) recommended fix.

@Donnie-Ice Donnie-Ice merged commit 7971deb into dev Nov 12, 2024
10 checks passed
@Donnie-Ice Donnie-Ice deleted the 347-calling-crypto_shutdown-twice-in-a-row-causes-a-core-dump branch November 12, 2024 15:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Calling crypto_shutdown() twice in a row causes a core dump
4 participants