Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packaging improvements #278

Merged
merged 1 commit into from
Aug 20, 2024
Merged

Packaging improvements #278

merged 1 commit into from
Aug 20, 2024

Conversation

Niautanor
Copy link
Contributor

  1. It is now possible to install the library to an arbitrary prefix by setting CMAKE_INSTALL_PREFIX and SYSTEM_INSTALL
  2. The filename of the library no longer conflicts with openssl when installed. This should not have an effect when using the library as a git submodule.

Closes #271

1. It is now possible to install the library to an arbitrary prefix by
   setting CMAKE_INSTALL_PREFIX and SYSTEM_INSTALL
2. The filename of the library no longer conflicts with openssl when
   installed. This should not have an effect when using the library as a
   git submodule.
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.29%. Comparing base (ee6d707) to head (0989519).

Additional details and impacted files
@@           Coverage Diff           @@
##              dev     #278   +/-   ##
=======================================
  Coverage   83.29%   83.29%           
=======================================
  Files          39       39           
  Lines       11049    11049           
  Branches      832      832           
=======================================
  Hits         9203     9203           
  Misses       1544     1544           
  Partials      302      302           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjbrown2
Copy link
Contributor

Looks good. Awaiting review from others.

@jlucas9 jlucas9 merged commit ae02d55 into nasa:dev Aug 20, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants