Cryptolib#256 - SA Update, Managed Parameters, UTs #273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d recurison to array insertion. Updated unit tests
# Conflicts: # include/crypto_error.h # src/core/crypto_error.c # support/scripts/build_kmc.sh
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #273 +/- ##
==========================================
+ Coverage 82.98% 83.29% +0.30%
==========================================
Files 41 39 -2
Lines 10385 11049 +664
Branches 832 832
==========================================
+ Hits 8618 9203 +585
- Misses 1469 1544 +75
- Partials 298 302 +4 ☔ View full report in Codecov by Sentry. |
dccutrig
approved these changes
Aug 16, 2024
Donnie-Ice
approved these changes
Aug 16, 2024
jlucas9
approved these changes
Aug 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit contains changes to Managed Parameters configurations (Accepts a struct now instead of all the variables within the stuct). This included reworking security associations to be more formal, and to have different keys, and follow basic key assignment rules (unit tests ignore these rules). Additionally all unit tests of the internal builds have been reworked to function properly with this change. The KMC (MDB) side of things will still need its tests fixed and re-written.
Merging this in before it gets out of control working on simplifying configurations.