268 oob read branch rebase #269
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #269 +/- ##
==========================================
+ Coverage 82.84% 82.98% +0.13%
==========================================
Files 41 41
Lines 10337 10385 +48
Branches 830 832 +2
==========================================
+ Hits 8564 8618 +54
+ Misses 1472 1469 -3
+ Partials 301 298 -3 ☔ View full report in Codecov by Sentry. |
dccutrig
reviewed
Aug 5, 2024
There was a problem hiding this comment.
maybe (spi >= NUM_SA) ? indices start at 0... just need to do a sanity check on this.
jlucas9
approved these changes
Aug 6, 2024
rjbrown2
approved these changes
Aug 7, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolved seg faults from sa index out of bounds