197 aes gcm siv #265
Merged
197 aes gcm siv #265
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@jlucas9 |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #265 +/- ##
==========================================
+ Coverage 82.68% 82.84% +0.16%
==========================================
Files 40 41 +1
Lines 10026 10337 +311
Branches 814 830 +16
==========================================
+ Hits 8290 8564 +274
- Misses 1437 1472 +35
- Partials 299 301 +2 ☔ View full report in Codecov by Sentry. |
|
Can we fix or verify the issues with the RHEL/WOLF builds before we approve, please? |
Donnie-Ice
force-pushed
the
197-aes-gcm-siv
branch
from
3b95f7f
to
48a19cd
Compare
jlucas9
reviewed
Aug 1, 2024
| @@ -422,6 +422,20 @@ static int32_t cryptography_encrypt(uint8_t* data_out, size_t len_data_out, | |||
| } | |||
| break; | |||
|
|
|||
| // TODO: Confirm same process as above for SIV | |||
There was a problem hiding this comment.
Should these three new comment blocks be removed?
dccutrig
approved these changes
Aug 5, 2024
jlucas9
approved these changes
Aug 5, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Allows for AES-GCM-SIV Enc/Dec. Examples are supplied via unit tests in
ut_aes_gcm_siv.c.