Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Key Mapping #198 #255

Merged
merged 1 commit into from
Jul 10, 2024
Merged

Update Key Mapping #198 #255

merged 1 commit into from
Jul 10, 2024

Conversation

rjbrown2
Copy link
Contributor

Handles the internal side for now.

Additional Queries will be needed for MariaDB. (Should hopefully be simple to implement on KMC side once we have automated containers for testing.

Added -DKEY_VALIDATION flags for ease of use later.

These changes will require us to tackle the SA modifications sooner than later, and then rework unit tests.

@jlucas9:
Should we create a separate issue for MDB/KMC additions, or leave this issue open for now?

@rjbrown2 rjbrown2 added the enhancement New feature or request label Jun 26, 2024
@rjbrown2 rjbrown2 self-assigned this Jun 26, 2024
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 23 lines in your changes missing coverage. Please review.

Project coverage is 82.49%. Comparing base (3c2a3d4) to head (ab6f0ec).

Files Patch % Lines
src/sa/internal/sa_interface_inmemory.template.c 0.00% 23 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #255      +/-   ##
==========================================
- Coverage   82.68%   82.49%   -0.19%     
==========================================
  Files          40       40              
  Lines       10026    10049      +23     
  Branches      814      818       +4     
==========================================
  Hits         8290     8290              
- Misses       1437     1460      +23     
  Partials      299      299              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@rjbrown2
Copy link
Contributor Author

@jlucas9 :
Should note that I did not include the Zero check for ekid/akid that we discussed. I was incorrect in my assumption of how they are initialized. They are not set to 0, they are set initially to the same as the SPI. So a fresh SA without any internal configuration, for example: SA:1 will have EKID=1, AKID=1, and SA:2, EKID=2, AKID=2. We may want to reconsider this in our init function, or just ignore if they are the same as the SPI (but could have weird edge cases).

Copy link
Collaborator

@jlucas9 jlucas9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, can create new issues for KMC side

@rjbrown2 rjbrown2 merged commit 8647af0 into dev Jul 10, 2024
5 checks passed
@jlucas9 jlucas9 deleted the 198-key-mapping branch August 1, 2024 23:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants