[nasa/cryptolib#244] Added has_ocf field to Crypto_Config_Add_Gvcid_M… #254
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…er function calls
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #254 +/- ##
==========================================
+ Coverage 82.67% 82.71% +0.04%
==========================================
Files 39 39
Lines 10020 10022 +2
Branches 813 813
==========================================
+ Hits 8284 8290 +6
+ Misses 1436 1434 -2
+ Partials 300 298 -2 ☔ View full report in Codecov by Sentry. |
jlucas9
reviewed
Jun 11, 2024
| @@ -497,6 +500,7 @@ int32_t Crypto_Config_Add_Gvcid_Managed_Parameter(uint8_t tfvn, uint16_t scid, u | |||
| gvcid_managed_parameters->vcid = vcid; | |||
| gvcid_managed_parameters->has_fecf = has_fecf; | |||
| gvcid_managed_parameters->has_segmentation_hdr = has_segmentation_hdr; | |||
| gvcid_managed_parameters->has_ocf = has_ocf; | |||
There was a problem hiding this comment.
Just calling this out as what the goal of the issue was - looks good!
jlucas9
approved these changes
Jun 11, 2024
williamposey
approved these changes
Jun 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added has_ocf field to all Crypto_Config_Add_Gvcid_Managed_Parameter() function calls. May need to revisit unit tests to ensure everything is being covered.