[nasa/cryptolib#211] Modify sadb_get_sa_from_spi. Unnecessary NULL #238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #238 +/- ##
=======================================
Coverage 73.94% 73.94%
=======================================
Files 8 8
Lines 2905 2905
Branches 459 459
=======================================
Hits 2148 2148
Misses 583 583
Partials 174 174 ☔ View full report in Codecov by Sentry. |
jlucas9
approved these changes
May 1, 2024
dccutrig
approved these changes
May 2, 2024
Donnie-Ice
approved these changes
May 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#184
The unnecessary reference to a null SA has been removed.
The function has been reworked to work better (more correctly) with the new internal SA setup.
The previous memory leak referenced by this issue has been removed already. We no longer calloc the arsn or iv within the internal sa in this manner.
Consider when reviewing this, if we should modify the character pointers within our SAs to be a set array length. (This would also aid in more easily saving those values in the upcoming save/load capabilities.