Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge TM Cyclomatic Complexity -> Dev #235

Merged
merged 6 commits into from
Apr 4, 2024

Conversation

rjbrown2
Copy link
Contributor

@rjbrown2 rjbrown2 commented Apr 3, 2024

Refactor of TM, and other minor functions to reduce cyclomatic complexity within crypto_tc.c

FYI:
crypto_tm.c:
Crypto_TM_Apply_Security (56 | 14)
Crypto_TM_Process_Security(46 | 11)

All new functions are below the required 16 CC metric as well.

@rjbrown2 rjbrown2 self-assigned this Apr 3, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 3, 2024

Codecov Report

Attention: Patch coverage is 76.37795% with 90 lines in your changes are missing coverage. Please review.

Project coverage is 73.95%. Comparing base (11a14ef) to head (826c275).
Report is 31 commits behind head on dev.

Files Patch % Lines
src/core/crypto_tm.c 76.37% 66 Missing and 24 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##              dev     #235      +/-   ##
==========================================
+ Coverage   72.00%   73.95%   +1.94%     
==========================================
  Files           8        8              
  Lines        2668     2906     +238     
  Branches      427      458      +31     
==========================================
+ Hits         1921     2149     +228     
- Misses        583      584       +1     
- Partials      164      173       +9     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

src/core/crypto_tm.c Outdated Show resolved Hide resolved
src/core/crypto_tm.c Show resolved Hide resolved
@rjbrown2 rjbrown2 merged commit 58f82ff into dev Apr 4, 2024
5 checks passed
@rjbrown2 rjbrown2 deleted the 230-cyclomatic-complexity-tm-apply-security branch April 4, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants