RC 1.3.0 #210
Merged
RC 1.3.0 #210
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Gitlab ENV Variables do not seem to be passing to this container.
# Conflicts: # .github/workflows/mariadb.yml # CMakeLists.txt # src/sa/mariadb/sadb_routine_mariadb.template.c # test/CMakeLists.txt # test/tests/ut_kmc_crypto_with_mtls_sadb.c # util/CMakeLists.txt
…ing on build type;
…ons as well as the support and test folders entirely;
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #210 +/- ##
==========================================
+ Coverage 67.27% 72.00% +4.72%
==========================================
Files 25 8 -17
Lines 9617 2668 -6949
Branches 0 427 +427
==========================================
- Hits 6470 1921 -4549
+ Misses 3147 583 -2564
- Partials 0 164 +164 ☔ View full report in Codecov by Sentry. |
rjbrown6
reviewed
Dec 14, 2023
| #include "cryptography_interface.h" | ||
| #include "key_interface.h" | ||
| #include "mc_interface.h" | ||
| #include "sa_interface.h" | ||
|
|
||
| /* | ||
| ** Crypto Version | ||
| */ | ||
| #define CRYPTO_LIB_MAJOR_VERSION 1 |
There was a problem hiding this comment.
Not sure we're using this any longer. If we are, it will need updated.
Remove old build status badges.
Update README.md
* Update build.yml Fixing Code Coverage - Test * Update build.yml Add Token for broken CodeCov pushes.
dccutrig
approved these changes
Jan 2, 2024
jlucas9
approved these changes
Jan 3, 2024
|
Looking to close this out in the next two weeks! |
|
Need to resolve #218 prior to merge |
|
Approved in latest internal meetings by all parties. As issues continue to be found new tickets can be created and patch releases done. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge Development into Main for upcoming release.