Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ut tc apply enctests #21

Merged
merged 28 commits into from
Dec 6, 2021
Merged

Ut tc apply enctests #21

merged 28 commits into from
Dec 6, 2021

Conversation

dccutrig
Copy link
Contributor

@dccutrig dccutrig commented Dec 6, 2021

No description provided.

rjbrown6 and others added 25 commits November 17, 2021 17:42
@rjbrown6
Rebasing to collab_main, Bug Fixes, additional tests
a2c9b0c
@rjbrown6
Added Dat files, and minor ut fixes - still faulting atm
5b479d9
@rjbrown6
UT/EVT refactoring
b58c258
@rjbrown6
Fixing CMake & Refactoring - broken validation
a244f1d
@rjbrown6
Fixing another CMake
e9e589e
@rjbrown6
Bug Fixes, UT Fixed with new layout, TODO: Find FECF Issue
50860c7
@rjbrown6
WIP
c6b302c
@dccutrig
Updates to error codes and unit tests
99e36b3
@dccutrig
WIP - AES-GCM test vector working
fdfcb12
@dccutrig
WIP - improving NIST KAT
ecf896b
@dccutrig
WIP - Troubleshooting commit
e24dac9
@dccutrig
Revert "WIP - Troubleshooting commit"
5eb7651 
This reverts commit e24dac9.
@dccutrig
Initial UT/Validation tests working
c8c2c8b
@dccutrig
WIP UT modify ek_ring from hex string
000db18
@rjbrown6
Key Functionality
356d662
@rjbrown6
Test Cleanup
262bbbe
@dccutrig
Adding more NIST AES-GCM 256 encryption test vectors
d3f3f81
@dccutrig
Added NIST authentication tag test
a92fd8f
@rjbrown6
WIP: FECF Issues
5ed6389
@rjbrown6
Fixed IV_SIZE, FECF_CALC, Added DEC Tests, TODO: AUT Dec + Test, more…
556917d 
… FECF Fix, MAC Test, Remove Dat Files
@rjbrown6
Fixed Unit Tests, Cleaning up Tests, Renamed et_xxx to et_dt_xxx, TOD…
76cc822 
…O: Finish removing dat files, finish validation tests
@rjbrown6
renamed c/h files
ff1c098
@rjbrown6
WIP: AUTH Decryption
0dae776
@rjbrown6
WIP: All Tests working but MAC Only AUTH Apply/Process
0dc6c40
@dccutrig
Encryption and decryption tests completed
934b8b8
IbraheemYSaleh
IbraheemYSaleh approved these changes Dec 6, 2021
View reviewed changes
Copy link
Contributor

@IbraheemYSaleh IbraheemYSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We reviewed this together in real time ... Looks good other than a few hard-coded IV length values and the deleted test apps. Please merge once you've fixed what needs fixing.

fsw/crypto_util/app/apply_security.c Outdated Show resolved Hide resolved
@dccutrig dccutrig merged commit 47e3e56 into collab_main Dec 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbraheemYSaleh IbraheemYSaleh IbraheemYSaleh approved these changes

@jlucas9 jlucas9 Awaiting requested review from jlucas9

@szemerick szemerick Awaiting requested review from szemerick

@rjbrown2 rjbrown2 Awaiting requested review from rjbrown2

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dccutrig @IbraheemYSaleh @rjbrown6