Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[nasa/cryptolib#144] WolfSSL Crypto Module #200

Merged
merged 51 commits into from
Oct 4, 2023
Merged

Conversation

jlucas9
Copy link
Collaborator

@jlucas9 jlucas9 commented Sep 26, 2023

Closes #144

@jlucas9 jlucas9 self-assigned this Sep 26, 2023
@codecov-commenter
Copy link

codecov-commenter commented Sep 26, 2023

Codecov Report

Merging #200 (361424a) into dev (dfe5643) will decrease coverage by 0.63%.
Report is 22 commits behind head on dev.
The diff coverage is 80.11%.

@@            Coverage Diff             @@
##              dev     #200      +/-   ##
==========================================
- Coverage   85.54%   84.92%   -0.63%     
==========================================
  Files          32       33       +1     
  Lines        7861     7913      +52     
==========================================
- Hits         6725     6720       -5     
- Misses       1136     1193      +57     
Files Coverage Δ
src/core/crypto_error.c 34.37% <ø> (ø)
test/unit/ut_crypto.c 100.00% <100.00%> (ø)
test/unit/ut_crypto_config.c 100.00% <100.00%> (ø)
test/unit/ut_tc_process.c 100.00% <ø> (ø)
test/unit/ut_tm_apply.c 99.44% <ø> (-0.56%) ⬇️
test/unit/ut_tm_process.c 100.00% <100.00%> (ø)
src/core/crypto_tc.c 84.37% <98.03%> (+0.04%) ⬆️
...gcrypt/cryptography_interface_libgcrypt.template.c 62.17% <50.00%> (-0.19%) ⬇️
...wolfssl_stub/cryptography_interface_wolfssl.stub.c 0.00% <0.00%> (ø)
src/sa/internal/sa_interface_inmemory.template.c 79.19% <88.88%> (+1.14%) ⬆️
... and 4 more

@jlucas9 jlucas9 added the cmp NASA GSFC CMP label Oct 4, 2023
Copy link
Contributor

@rjbrown2 rjbrown2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Sorry for my spam while experimenting with the build.yml

Copy link
Contributor

@dccutrig dccutrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, like the pointing of stubs for different crypto libraries to return NULL.

@jlucas9 jlucas9 merged commit 016729b into dev Oct 4, 2023
4 checks passed
@jlucas9 jlucas9 deleted the cryptolib#144-WolfSSL branch October 4, 2023 20:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp NASA GSFC CMP
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants