Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

201 cryptolib add tm support #199

Merged
merged 12 commits into from
Sep 15, 2023
Merged

201 cryptolib add tm support #199

merged 12 commits into from
Sep 15, 2023

Conversation

dccutrig
Copy link
Contributor

No description provided.

@dccutrig dccutrig self-assigned this Sep 15, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #199 (eb19944) into dev (dfe5643) will decrease coverage by 0.35%.
Report is 9 commits behind head on dev.
The diff coverage is 79.00%.

@@            Coverage Diff             @@
##              dev     #199      +/-   ##
==========================================
- Coverage   85.54%   85.20%   -0.35%     
==========================================
  Files          32       32              
  Lines        7861     7906      +45     
==========================================
+ Hits         6725     6736      +11     
- Misses       1136     1170      +34     
Files Changed Coverage Δ
src/core/crypto_error.c 34.37% <ø> (ø)
test/unit/ut_tc_process.c 100.00% <ø> (ø)
test/unit/ut_tm_apply.c 100.00% <ø> (ø)
...gcrypt/cryptography_interface_libgcrypt.template.c 62.17% <50.00%> (-0.19%) ⬇️
src/core/crypto.c 93.75% <65.30%> (-2.15%) ⬇️
src/core/crypto_tm.c 76.61% <71.59%> (-1.11%) ⬇️
src/core/crypto_config.c 81.02% <84.21%> (-1.10%) ⬇️
src/sa/internal/sa_interface_inmemory.template.c 79.19% <88.88%> (+1.14%) ⬆️
src/core/crypto_tc.c 84.30% <94.11%> (-0.03%) ⬇️
test/unit/ut_crypto.c 100.00% <100.00%> (ø)
... and 2 more

CMakeLists.txt Outdated Show resolved Hide resolved
Crypto_Config_Add_Gvcid_Managed_Parameter(0, 0x002c, 0, TM_HAS_FECF, TM_SEGMENT_HDRS_NA, 1786);
Crypto_Config_Add_Gvcid_Managed_Parameter(0, 0x0003, 0, TM_HAS_FECF, TM_SEGMENT_HDRS_NA, 1786);
Crypto_Config_Add_Gvcid_Managed_Parameter(0, 0x002c, 0, TM_NO_FECF, TM_SEGMENT_HDRS_NA, 1786);
Crypto_Config_Add_Gvcid_Managed_Parameter(0, 0x0042, 0, TM_NO_FECF, TM_SEGMENT_HDRS_NA, 1786);
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do these impact our default SA assumptions for later testing with KMC?

src/core/crypto.c Outdated Show resolved Hide resolved
src/core/crypto_tm.c Outdated Show resolved Hide resolved
"reset - Reset CryptoLib \n"
"tc - Toggle TC debug prints \n"
"tm - Toggle TM debug prints \n"
"vcid # - Change active TC virtual channel \n"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This line spawned a thought, how would we change the active TM virtual channel in FSW?

@dccutrig dccutrig merged commit bd6b016 into dev Sep 15, 2023
3 checks passed
This was referenced Sep 25, 2023
@jlucas9 jlucas9 deleted the 201-cryptolib-add-tm-support branch December 13, 2023 17:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants