Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cryptolib#164 tm multiple packets #174

Merged
merged 12 commits into from
Jun 22, 2023
Merged

Conversation

jlucas9
Copy link
Collaborator

@jlucas9 jlucas9 commented Jun 22, 2023

Redo merge request into dev branch as it should be.

@jlucas9 jlucas9 requested a review from dccutrig June 22, 2023 18:09
@jlucas9 jlucas9 self-assigned this Jun 22, 2023
@codecov-commenter
Copy link

Codecov Report

Merging #174 (22b1bdc) into dev (88a4a0e) will decrease coverage by 0.27%.
The diff coverage is 95.38%.

@@            Coverage Diff             @@
##              dev     #174      +/-   ##
==========================================
- Coverage   86.15%   85.89%   -0.27%     
==========================================
  Files          31       29       -2     
  Lines        7902     7634     -268     
==========================================
- Hits         6808     6557     -251     
+ Misses       1094     1077      -17     
Impacted Files Coverage Δ
src/core/crypto_error.c 34.37% <ø> (ø)
test/unit/ut_mysql_m_tls_connection.c 0.00% <0.00%> (ø)
test/unit/ut_mysql_tls_connection.c 0.00% <0.00%> (ø)
test/unit/ut_sadb_err_cases_kmc_crypto.c 0.00% <0.00%> (ø)
src/core/crypto_tm.c 77.66% <77.77%> (+0.77%) ⬆️
src/sa/internal/sadb_routine_inmemory.template.c 78.04% <85.00%> (-0.73%) ⬇️
src/core/crypto_tc.c 89.43% <94.59%> (+0.88%) ⬆️
test/unit/ut_tc_apply.c 99.35% <96.87%> (-0.17%) ⬇️
src/core/crypto.c 95.89% <100.00%> (ø)
src/core/crypto_config.c 82.25% <100.00%> (+0.06%) ⬆️
... and 6 more

... and 2 files with indirect coverage changes

Copy link
Contributor

@dccutrig dccutrig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved - same PR as before, just corrected base branch.

@dccutrig dccutrig merged commit 454eff7 into dev Jun 22, 2023
8 checks passed
@jlucas9 jlucas9 deleted the cryptolib#164-TM-Multiple-Packets branch June 22, 2023 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants