Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AKMC-113: Add SADB MariaDB code for working with MySQL BINARY fields #17

Merged
merged 1 commit into from
Dec 1, 2021

Conversation

IbraheemYSaleh
Copy link
Contributor

No description provided.

@@ -231,10 +243,45 @@ static int32 parse_sa_from_mysql_query(char* query, SecurityAssociation_t** secu

return status;
}
static int32 convert_hexstring_to_byte_array(char* source_str, uint8* dest_buffer)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I like this function - should we consider moving some of these helpers like this to a utils file / directory for access in other files e.g. crypto_util/src?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think the MariaDB/mysql source code should depend on the crypto_util source tree at this time... So far, everything under crypto_util are test & related helper applications/libraries, not things we expect end-users to use.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is an intermediary PR, there is still mysql integration work to do... since this is the only comment and the function can be refactored when needed, I'm going to proceed with the merge.

@IbraheemYSaleh IbraheemYSaleh merged commit e24fefb into collab_main Dec 1, 2021
@rjbrown2 rjbrown2 deleted the AKMC-113-pt2 branch December 16, 2021 22:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants