Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hmac fixes #112

Merged
merged 4 commits into from
May 4, 2022
Merged

Hmac fixes #112

merged 4 commits into from
May 4, 2022

Conversation

dccutrig
Copy link
Contributor

No description provided.

@dccutrig
Fix UTs failing due to incorrect key length, remove UTs that shouldnt…
506253d 
… work with 32 byte SHA512 key, adding error catching previous issue, commented out two test for future commit to investigate a segfault
@dccutrig
Fix UTs setup improperly
f6dc8a1
@dccutrig
Update UT originally created with wrong MAC key
5223bef
@dccutrig
Segfault was caused by UT error, not a code error. Since the relevant…
afce6dc 
… code is already exercised, removed problematic UTs.
@dccutrig dccutrig linked an issue Apr 27, 2022 that may be closed by this pull request
The Hmac SHA512 libgcrypt authenticate call breaks libgcrypt state at the gcry_mac_read function #100
Closed
@dccutrig dccutrig marked this pull request as ready for review April 27, 2022 15:06
IbraheemYSaleh
IbraheemYSaleh approved these changes May 4, 2022
View reviewed changes
Copy link
Contributor

@IbraheemYSaleh IbraheemYSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 very good ... so it seems like the segfault was caused by a wrong-length key being used. That makes a lot of sense... Great find!

@dccutrig dccutrig merged commit 7dd861c into dev May 4, 2022
@dccutrig dccutrig removed a link to an issue May 4, 2022
The Hmac SHA512 libgcrypt authenticate call breaks libgcrypt state at the gcry_mac_read function #100
Closed
@dccutrig dccutrig linked an issue May 4, 2022 that may be closed by this pull request
The Hmac SHA512 libgcrypt authenticate call breaks libgcrypt state at the gcry_mac_read function #100
Closed
@jlucas9 jlucas9 deleted the hmac_fixes branch March 23, 2023 15:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IbraheemYSaleh IbraheemYSaleh IbraheemYSaleh approved these changes

@rjbrown2 rjbrown2 rjbrown2 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

The Hmac SHA512 libgcrypt authenticate call breaks libgcrypt state at the gcry_mac_read function
3 participants
@dccutrig @IbraheemYSaleh @rjbrown2