88 add GitHub automated build integration tests for sadb mariadb interface 1 #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fixed CMAKE issue causing builds to fail. |
Codecov Report
@@ Coverage Diff @@
## dev #109 +/- ##
==========================================
- Coverage 80.27% 76.78% -3.50%
==========================================
Files 20 21 +1
Lines 5644 5901 +257
==========================================
Hits 4531 4531
- Misses 1113 1370 +257
Continue to review full report at Codecov.
|
|
Code coverage falls down a little with this because there's no code coverage module in my docker container with the mariadb installed. Didn't think about this, and I can work on it later if that's not a big deal to anyone else (don't know if there is a solution yet - there should be somewhere though). Should be good to merge w/o conflicts now. |
dccutrig
approved these changes
Apr 26, 2022
|
Excellent 👍 |
IbraheemYSaleh
approved these changes
May 4, 2022
jlucas9
deleted the
88-add-github-automated-build-integration-tests-for-sadb-mariadb-interface-1
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Docker Container to allow for SQL testing (MARIADB)
Added several unit tests, and modified yml to work within main/dev.
Additional tests could be written in the future when things are flushed out more. We could probably also use some additional tests now that I've not written, but I think the basis is covered.