Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

101 incorrect decryption logic for authentication #102

Merged
merged 3 commits into from
Apr 13, 2022

Conversation

dccutrig
Copy link
Contributor

Commented out two tests for now that are failing, but need to track down the root cause - don't believe it's directly related to this issue so planned to leave them commented out here in this PR.

@dccutrig dccutrig linked an issue Apr 13, 2022 that may be closed by this pull request
@codecov-commenter
Copy link

Codecov Report

Merging #102 (267ac6b) into dev (c2e9408) will increase coverage by 0.30%.
The diff coverage is 86.36%.

@@            Coverage Diff             @@
##              dev     #102      +/-   ##
==========================================
+ Coverage   82.49%   82.79%   +0.30%     
==========================================
  Files          19       19              
  Lines        5188     5296     +108     
==========================================
+ Hits         4280     4385     +105     
- Misses        908      911       +3     
Impacted Files Coverage Δ
util/src_util/ut_crypto.c 100.00% <ø> (ø)
...gcrypt/cryptography_interface_libgcrypt.template.c 83.37% <82.35%> (-0.03%) ⬇️
src/src_main/crypto_tc.c 91.09% <100.00%> (+0.04%) ⬆️
util/src_util/et_dt_validation.c 98.85% <100.00%> (+0.07%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c2e9408...267ac6b. Read the comment docs.

Copy link
Contributor

@IbraheemYSaleh IbraheemYSaleh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See comments above.

@dccutrig dccutrig merged commit 382990d into dev Apr 13, 2022
@jlucas9 jlucas9 deleted the 101-incorrect-decryption-logic-for-authentication branch March 23, 2023 15:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Incorrect decryption logic for authentication
3 participants