Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crypto.C - Cleanup #316

Open
10 of 11 tasks
rjbrown2 opened this issue Sep 17, 2024 · 2 comments
Open
10 of 11 tasks

Crypto.C - Cleanup #316

rjbrown2 opened this issue Sep 17, 2024 · 2 comments
Assignees

Comments

@rjbrown2
Copy link
Contributor

rjbrown2 commented Sep 17, 2024

  • Check IV-len against maximum IV- Length (Will need to be defined)
  • Check Gvcid Counter against bounds
  • Check for Null Pointers
  • Check for Size > 0
  • Clean up Commented COde
  • Finish or Remove TODOS
  • (~Line 147) - Add return code, and fix to single return statement
  • (235 - Unused Code) Remove?
  • Remove //Testing Code Comment - and specify what these are
  • Remove Magic Numbers
  • Add more comments
@rjbrown2
Copy link
Contributor Author

This can probably be combined with #315

@Donnie-Ice
Copy link
Contributor

Not sure about cases of Check for Size > 0. For-loops do that automatically. Marking as complete for now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

When branches are created from issues, their pull requests are automatically linked.

2 participants