Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Cmake Install Path #293

Closed
rjbrown2 opened this issue Sep 11, 2024 · 1 comment · Fixed by #294
Closed

Update Cmake Install Path #293

rjbrown2 opened this issue Sep 11, 2024 · 1 comment · Fixed by #294
Assignees
Labels
cmp NASA GSFC CMP

Comments

@rjbrown2
Copy link
Contributor

          Just caught this; I reccomend changing line 132 from `set(CMAKE_INSTALL_RPATH "${CMAKE_INSTALL_PREFIX}/cpu${TGTSYS_${SYSVAR}}/${INSTALL_SUBDIR}")` to `set(CMAKE_INSTALL_RPATH "./${INSTALL_SUBDIR}")`

Originally posted by @williamposey in #276 (comment)

@rjbrown2
Copy link
Contributor Author

williamposey 11 hours ago
If I can sneak in another change, it would be helpful to add install(TARGETS crypto RUNTIME_DEPENDENCIES DESTINATION ${CMAKE_INSTALL_PREFIX}/${TGTSYS_${SYSVAR}}/${INSTALL_SUBDIR}) right after add_cfe_app(crypto ${LIB_SRC_FILES}).

This, along with the change mentioned above to set(CMAKE_INSTALL_RPATH "./${INSTALL_SUBDIR}") would allow for any dependencies, like wolfssl, to be installed into the cf/ folder alongside cryptolib, and set the runtime search path to the cf/ folder to find it, for cFS integration.

If this can't make it into this PR then no problem and I can move it to another issue; let me know! Thanks

@rjbrown2 rjbrown2 self-assigned this Sep 11, 2024
@williamposey williamposey added the cmp NASA GSFC CMP label Sep 11, 2024
@rjbrown2 rjbrown2 linked a pull request Sep 11, 2024 that will close this issue
rjbrown2 added a commit that referenced this issue Sep 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cmp NASA GSFC CMP
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants