-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-9261: When delete a draft, remove it from database, not tombstone it… #1955
Conversation
Codecov Report
@@ Coverage Diff @@
## master #1955 +/- ##
==========================================
- Coverage 55.49% 55.41% -0.08%
==========================================
Files 993 993
Lines 62805 62898 +93
Branches 1542 1542
==========================================
+ Hits 34852 34857 +5
- Misses 26415 26499 +84
- Partials 1538 1542 +4
|
@@ -230,7 +230,9 @@ | |||
request-context :update :provider-object provider-id) | |||
(acl/verify-provider-context-permission | |||
request-context :read :provider-object provider-id))] | |||
(api-core/delete-concept concept-type provider-id native-id request))) | |||
(if (is-draft-concept? request) | |||
(api-core/delete-draft concept-type provider-id native-id request) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the delete-draft
function in ingest/core leave a tombstone? If it does not we should update the doc-string in this function with something like Deletes a generic document in elasticsearch and creates a tombstone in the database if the concept is not a draft concept.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
updated the doc string.
… it.