-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
CMR-9303: Remove Legacy Services code from Transmit #1953
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #1953 +/- ##
==========================================
- Coverage 55.49% 55.32% -0.17%
==========================================
Files 993 990 -3
Lines 62805 62641 -164
Branches 1540 1538 -2
==========================================
- Hits 34852 34656 -196
- Misses 26415 26449 +34
+ Partials 1538 1536 -2
|
zimzoom
approved these changes
Aug 14, 2023
jceaser
approved these changes
Aug 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Transmit had no direct calls to cmr-soap-services code, so the focus here was on removing code related to ECHO. Pieces of code related to ECHO were in the transmit.echo folder and in the config.clj. Unfortunately the code was not able to be fully removed. Mock-echo has some dependence on parts of the code in transmit. The parts that were not needed in transmit were moved into mock-echo, and the part that could not be moved out of transmit will be addressed in CMR-9320