Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9303: Remove Legacy Services code from Transmit #1953

Merged
merged 31 commits into from
Aug 15, 2023
Merged

Conversation

TylerHeald1
Copy link
Contributor

Transmit had no direct calls to cmr-soap-services code, so the focus here was on removing code related to ECHO. Pieces of code related to ECHO were in the transmit.echo folder and in the config.clj. Unfortunately the code was not able to be fully removed. Mock-echo has some dependence on parts of the code in transmit. The parts that were not needed in transmit were moved into mock-echo, and the part that could not be moved out of transmit will be addressed in CMR-9320

@codecov-commenter
Copy link

codecov-commenter commented Aug 11, 2023

Codecov Report

Merging #1953 (71023ec) into master (8c3e87e) will decrease coverage by 0.17%.
The diff coverage is 14.70%.

@@            Coverage Diff             @@
##           master    #1953      +/-   ##
==========================================
- Coverage   55.49%   55.32%   -0.17%     
==========================================
  Files         993      990       -3     
  Lines       62805    62641     -164     
  Branches     1540     1538       -2     
==========================================
- Hits        34852    34656     -196     
- Misses      26415    26449      +34     
+ Partials     1538     1536       -2     
Files Changed Coverage Δ
...pp/src/cmr/access_control/services/acl_service.clj 12.29% <ø> (ø)
...l-app/src/cmr/access_control/services/acl_util.clj 9.67% <ø> (ø)
...-app/src/cmr/access_control/services/auth_util.clj 15.90% <0.00%> (ø)
.../src/cmr/access_control/services/group_service.clj 16.88% <ø> (ø)
.../common_app/api/request_context_user_augmenter.clj 58.53% <ø> (ø)
dev-system/src/cmr/dev_system/control.clj 19.00% <0.00%> (ø)
ingest-app/src/cmr/ingest/api/core.clj 29.54% <ø> (ø)
...ck-echo-app/src/cmr/mock_echo/client/echo_util.clj 25.41% <0.00%> (ø)
...-app/src/cmr/mock_echo/client/mock_echo_client.clj 22.22% <0.00%> (ø)
...r/search/services/humanizers/humanizer_service.clj 23.68% <ø> (ø)
... and 2 more

... and 1 file with indirect coverage changes

@TylerHeald1 TylerHeald1 merged commit 11ce466 into master Aug 15, 2023
1 check passed
@TylerHeald1 TylerHeald1 deleted the CMR-9303 branch August 15, 2023 17:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants