Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CMR-9324: GraphDB Builds Failing Snyk Scan #1950

Merged
merged 1 commit into from
Aug 4, 2023
Merged

Conversation

johnwteague
Copy link
Contributor

@johnwteague johnwteague commented Aug 3, 2023

Result of "npm audit fix"

@eudoroolivares2016 eudoroolivares2016 changed the title CMR-9324 fix snyk vuln CMR-9324: GraphDB Builds Failing Snyk Scan Aug 3, 2023
@eudoroolivares2016
Copy link
Contributor

eudoroolivares2016 commented Aug 4, 2023

I Ran the indexer function locally with npx sls invoke local --function bootstrapGremlinServer --path local-bootstrap.json the collections seemed to populate the graph as expected. used the gremlin console to look around in the gremlin server instance and things seemed to be working i.e. they have expected properties. That is a big npm update but, it does pass all tests and behavior looks correct. Also if you do end up wanting to try that out you just need to start the docker containers which are in the README.md and unfortnetly for local dev you have to comment out the VPC groups and the SQS queue declared in the serverless.yaml file (lines 16-29 and lines 23 and 24)

@johnwteague
Copy link
Contributor Author

@eudoroolivares2016 Thanks for running the tests, that's really helpful. That is not documented in the README.md though, that I see. Following the readme, I did start gremlin-server and run "npm run test" but that's all I knew to do from reading the doc.

@eudoroolivares2016
Copy link
Contributor

@johnwteague Yea that was originally a stop-gap until the local SQS queue would work but, trying to get that running hasn't completed. Since others might start working in this even just for Snyk I can write a ticket to update documentation in there for the npx sls calls. The gremlin-console is in the README.md that one is just another docker container and then you run a few commands in the CLI terminal that the docker container brings up to have it talk to the gremlin server instance

@johnwteague johnwteague merged commit ada66c0 into master Aug 4, 2023
2 checks passed
johnwteague added a commit that referenced this pull request Aug 4, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants