Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add scrubbing support for libraries #27

Closed
3 tasks done
jhnphm opened this issue May 11, 2022 · 1 comment · Fixed by #37
Closed
3 tasks done

Add scrubbing support for libraries #27

jhnphm opened this issue May 11, 2022 · 1 comment · Fixed by #37
Assignees
@dzbaker
Labels
draco-rc3 enhancement
Milestone
Draco

Comments

@jhnphm
Copy link

jhnphm commented May 11, 2022

Checklist (Please check before submitting)

  • I reviewed the Contributing Guide.
  • I reviewed the README file to see if the feature is in the major future work.
  • I performed a cursory search to see if the feature request is relevant, not redundant, nor in conflict with other tickets.

Is your feature request related to a problem? Please describe.
CS currently doesn't support scrubbing libraries. This could be implemented now that ticket nasa/cFE#28 is implemented.

Describe the solution you'd like
Add a field in the app table to specify whether or not an entry belongs to an app or a lib and call the appropriate API functions accordingly

Describe alternatives you've considered
Add a separate dedicated lib table, or perhaps call CFE_ES_GetAppIDByName first and if that fails, call CFE_ES_GetLibIDByName, then call CFE_ES_GetModuleInfo() to get the addresses to scrub

Requester Info
John N Pham, Northrop Grumman
@skliper
Copy link
Contributor

skliper commented May 20, 2022

I like just trying CFE_ES_GetAppIDByName, then CFE_ES_GetLibIDByName if the former fails.

@skliper skliper added this to the Draco milestone Jun 13, 2022
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 21, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
d506c2c 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 21, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
d9ad672 
…nction.
@dzbaker dzbaker mentioned this issue Jul 21, 2022
Merged
2 tasks
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 21, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
bdb3d67 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
d1854d2 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
8120abb 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
48c99ec 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
9318197 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
5f08a14 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
b087066 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
719b2cd 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
6f31952 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 25, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
c0a3ecc 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 26, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
74e72a7 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 26, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
925bf4e 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 26, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
cd03ec2 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 26, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
e918aec 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 26, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
c32a039 
…nction.
dzbaker added a commit to dzbaker/CS that referenced this issue Jul 26, 2022
@dzbaker
Fix nasa#27, Add library support to application checksum computing fu…
7b106dc 
…nction.
dzbaker added a commit that referenced this issue Jul 28, 2022
@dzbaker
Merge pull request #37 from dzbaker/fix27-library_scrubbing_support
4280e14 
Fix #27, Add library support to application checksum computing function.
skliper pushed a commit to skliper/CS that referenced this issue Sep 9, 2022
@astrogeco
Merge pull request nasa#27 from skliper/fix25-run_workflow_failure_ev…
82f2a06 
…ent_text

Fix nasa#25, RTS not loaded event no longer implies failure in text
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@dzbaker dzbaker

Labels
draco-rc3 enhancement
Projects
None yet
Milestone
Draco
Development

Successfully merging a pull request may close this issue.

Fix #27, Add library support to application checksum computing function. dzbaker/CS
3 participants
@jhnphm @dzbaker @skliper