Fix #401, use valid size when calling CFE_MSG_Init #402
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Use the offset of the payload start, which by definition must include at least enough space for the primary header. This ensures that the value will pass any size check enforced in CFE_MSG_Init.
jphickey
added
the
CCB:Ready
dzbaker
added
CCB:Approved
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Use the offset of the payload start, which by definition must include at least enough space for the primary header. This ensures that the value will pass any size check enforced in CFE_MSG_Init.
Fixes #401
Testing performed
Found and Tested as part of the stakeholder software delivery
Expected behavior changes
CF sends PDUs successfully (with valid msgid)
Contributor Info - All information REQUIRED for consideration of pull request
Joseph Hickey, Vantage Systems, Inc.