Fix #283, pass correct parameter in Abandon cmd function #284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
havencarlson
added
the
CCB:Ready
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -538,7 +538,7 @@ | |||
| *-----------------------------------------------------------------*/ | |||
| void CF_CmdAbandon(CFE_SB_Buffer_t *msg) | |||
| { | |||
| if (CF_TsnChanAction((CF_TransactionCmd_t *)msg, "abandon", CF_CmdCancel_Txn, NULL) > 0) | |||
| if (CF_TsnChanAction((CF_TransactionCmd_t *)msg, "abandon", CF_CmdAbandon_Txn, NULL) > 0) | |||
Check warning
Code scanning / CodeQL-coding-standard
Side effect in a Boolean expression
semaldona
approved these changes
Jul 20, 2022
dzbaker
added
CCB:Approved
and removed
CCB:Ready
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist (Please check before submitting)
Describe the contribution
Fix #283,
CF_CmdCancel_Txnwas being passed toCF_TsnChanAction()instead ofCF_CmdAbandon_TxnTesting performed
Ran unit tests
Expected behavior changes
When the abandon command is called, it will run
CF_CmdAbandon_TxnSystem(s) tested on
Contributor Info - All information REQUIRED for consideration of pull request
Haven Carlson - NASA