Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

'EID' should be at the end of the Event ID names #338

Closed
2 tasks done
thnkslprpt opened this issue Oct 21, 2022 · 0 comments · Fixed by #339
Closed
2 tasks done

'EID' should be at the end of the Event ID names #338

thnkslprpt opened this issue Oct 21, 2022 · 0 comments · Fixed by #339
Labels
enhancement

Comments

@thnkslprpt
Copy link
Contributor

thnkslprpt commented Oct 21, 2022 •
edited
Loading

Checklist

  • I reviewed the Contributing Guide.
  • I performed a cursory search to see if the bug report is relevant, not redundant, nor in conflict with other tickets.

Describe the bug
During recent updates to the EIDs, it was noted that CF specifically has the 'EID' component of the Event ID names at the beginning rather than the end for almost all the Event IDs. All other cFS components/apps place it at the end of the Event ID.

Code snips
Screenshot 2022-10-22 07 52 12

Expected behavior
I think it is worth moving 'EID' to the end of the CF Event ID names to improve consistency across the cFS apps and ease the identification of EIDs from CF in general.

At the same time, it is probably worth moving the additional type parameter in the Event ID names (INF, ERR etc.) to the end as well, which is also the predominant convention in cFS.

Reporter Info
Avi Weiss @thnkslprpt
@thnkslprpt thnkslprpt changed the title Move 'EID' to the end of Event ID names 'EID' should be at the end of the Event ID names Oct 22, 2022
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Oct 22, 2022
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of the Event ID names
c4e3a63
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Oct 22, 2022
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
b3f1095
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Oct 22, 2022
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
ac32aa6
@thnkslprpt thnkslprpt mentioned this issue Oct 22, 2022
Merged
2 tasks
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Mar 12, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
7bae557
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Mar 12, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
8fb2054
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Mar 12, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
7c53410
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Mar 31, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
4db3179
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Apr 7, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
656df66
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Apr 17, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
73c0f57
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue May 19, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
5a32ce0
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Aug 19, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
2a7beba
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Aug 19, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
8b15ec3
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Aug 19, 2023
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
9773595
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Jul 9, 2024
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
1388d07
thnkslprpt added a commit to thnkslprpt/CF that referenced this issue Jul 9, 2024
@thnkslprpt
Fix nasa#338, Move 'EID' to the end of Event ID names
bf1c619
dzbaker added a commit that referenced this issue Jul 15, 2024
@dzbaker
Merge pull request #339 from thnkslprpt/fix-338-move-eid-to-end-of-ev…
86e5136 
…ent-id-names

Fix #338, Move 'EID' to the end of Event ID names
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Fix #338, Move 'EID' to the end of Event ID names thnkslprpt/CF
2 participants
@dzbaker @thnkslprpt