refactor: Simplify pd.ArrowDtype -> nw.DType#3413
Merged
dangotbanned merged 11 commits intomainfrom Jan 25, 2026
Merged
Conversation
Spotted while reviewing #3377 Pretty sure there's more of these to be found
Member
Author
|
@FBruzzesi AFAICT this is all good so far in (89efe94) I'm gonna start pulling at the rest and see how much can be removed before collapsing 😂 |
dangotbanned
commented
Jan 22, 2026
FBruzzesi
approved these changes
Jan 25, 2026
Member
FBruzzesi
left a comment
FBruzzesi
left a comment
There was a problem hiding this comment.
Thanks @dangotbanned - I left a couple of comments but feel free to merge as it is
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
We can skip a lot of string manipulation by just using
pandas.ArrowDtype.pyarrow_dtypePretty sure there's more of these to be found.
Was half expecting this to break in CI somehow, since it seemed too obvious
Related issues
DecimalDType #3377