feat: Add prefix argument to generate_temporary_column_name
#3147
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
for more information, see https://pre-commit.ci
FBruzzesi
changed the title
prefix argument to generate_temporary_column_name
FBruzzesi
commented
Sep 21, 2025
Comment on lines
-1276
to
+1284
| # Prepend `'nw'` to ensure it always starts with a character | ||
| # https://github.com/narwhals-dev/narwhals/issues/2510 | ||
| token = f"nw{token_hex(n_bytes - 1)}" | ||
| token = f"{prefix}{token_hex(n_bytes - 1)}" |
Member
Author
There was a problem hiding this comment.
Should we ensure that prefix is not an empty string?
32 tasks
MarcoGorelli
approved these changes
Sep 30, 2025
Comment on lines
-1276
to
+1284
| # Prepend `'nw'` to ensure it always starts with a character | ||
| # https://github.com/narwhals-dev/narwhals/issues/2510 | ||
| token = f"nw{token_hex(n_bytes - 1)}" | ||
| token = f"{prefix}{token_hex(n_bytes - 1)}" |
dangotbanned
added a commit
that referenced
this pull request
Sep 30, 2025
Still need to do `temp.column_names` as well That one is quite different to #3147, but was needed in this PR
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Checklist
If you have comments or can explain your changes, please do so below
Added explicit prefix only on lazy backends operations since these are the ones that a user might be able to investigate in various way. Not really applicable in the eager case