Skip to content

chore(typing): Ignore another EagerDataFrame intermittent [False Negative] #3142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarcoGorelli merged 3 commits into from
Oct 3, 2025
Merged

chore(typing): Ignore another EagerDataFrame intermittent [False Negative] #3142

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c9365d7
chore(typing): Ignore another `EagerDataFrame` intermittent [False Ne…
dangotbanned Sep 18, 2025
58223a4
Merge branch 'main' into eager-df-ignore-flaky
dangotbanned Sep 20, 2025
64904ed
Merge branch 'main' into eager-df-ignore-flaky
dangotbanned Sep 21, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions narwhals/_compliant/dataframe.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -321,8 +321,12 @@ def __narwhals_namespace__(
def to_narwhals(self) -> DataFrame[NativeDataFrameT]:
return self._version.dataframe(self, level="full")

def aggregate(self, *exprs: EagerExprT) -> Self:
# NOTE: Ignore intermittent [False Negative]
def aggregate(self, *exprs: EagerExprT) -> Self: # pyright: ignore[reportIncompatibleMethodOverride]
# NOTE: Ignore intermittent [False Negative] (1)
# Method "aggregate" overrides class "CompliantLazyFrame" in an incompatible manner
# Keyword parameter "exprs" type mismatch: base parameter is type "EagerExprT@EagerDataFrame", override parameter is type "EagerExprT@EagerDataFrame"
# Type "EagerExprT@EagerDataFrame" is not assignable to type "EagerExprT@EagerDataFrame"
# NOTE: Ignore intermittent [False Negative] (2)
# Argument of type "EagerExprT@EagerDataFrame" cannot be assigned to parameter "exprs" of type "EagerExprT@EagerDataFrame" in function "select"
# Type "EagerExprT@EagerDataFrame" is not assignable to type "EagerExprT@EagerDataFrame"
return self.select(*exprs) # pyright: ignore[reportArgumentType]
Expand Down
Loading