refactor(expr-ir): Generate dispatch methods #3068
Merged
+445
−396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangotbanned
changed the title
namespace helper
dangotbanned
commented
Aug 31, 2025
1 task
dangotbanned
added a commit
that referenced
this pull request
Sep 1, 2025
dangotbanned
added a commit
that referenced
this pull request
Sep 1, 2025
#3068 was what started all this
10 tasks
dangotbanned
changed the title
namespace helperHandled by #3073 **without** any other changes 🥳
will add some more ergonomic staticmethods next
Might be as far as it can go, without losing the typing for `node`
Not getting any typing benefits in `common`, so this is less complicated
The default is `groupwise`, didn't need repeating
Still have 17x references to the *now* unnecessary method
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
ExprIR(main) #3066Checklist
If you have comments or can explain your changes, please do so below
Note
Focused a bit too hard on getting a negative diff
What's more important is that this slows future growth
ExprDispatchwas only going to get bigger, and didn't include most of the functions yet