refactor: Split up BaseFrame._extract_compliant#3054
Merged
dangotbanned merged 17 commits intotrim-compliantfrom Aug 29, 2025
Merged
refactor: Split up BaseFrame._extract_compliant#3054dangotbanned merged 17 commits intotrim-compliantfrom
BaseFrame._extract_compliant#3054dangotbanned merged 17 commits intotrim-compliantfrom
Conversation
…ace.parse_into_expr` Clear separation of which namespaces accept non-trivial eager input
Main goal of (#3045 (comment))
- **Most** of `DataFrame._extract_compliant` is replaced now - Swapped this in for the other two locations it was duplicated
Seems like a pretty big oversight, gonna split into its own PR
None of this was needed after separating expression parsing from the rest (0a18a5e)
We couldn't do things like this before 😏
11 tasks
dangotbanned
commented
Aug 29, 2025
This was referenced Aug 29, 2025
MarcoGorelli
pushed a commit
that referenced
this pull request
Aug 29, 2025
`_utils.flatten` handles that case already https://github.com/narwhals-dev/narwhals/actions/runs/17332028942/job/49210052366?pr=3054
MarcoGorelli
approved these changes
Aug 29, 2025
Member
MarcoGorelli
left a comment
MarcoGorelli
left a comment
There was a problem hiding this comment.
seems reasonable, feel free to merge when ready
Member
Author
Phew 😅 thanks @MarcoGorelli! |
This was referenced Sep 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
Compliant*APIs #3045Compliant*APIs #3045 (comment))Compliant*methods #2713Checklist
If you have comments or can explain your changes, please do so below
Compliant*APIs #3045)*Framejoins #3055