fix: Use updated from_arrow import for modin
#2919
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dangotbanned
added
fix
bug: it raises an error but shouldn't
pandas-like
Member
Author
|
Note All of the test failures are unrelated See https://discord.com/channels/1235257048170762310/1284535800633229312/1400754991249227797 |
dangotbanned
commented
Aug 1, 2025
Comment on lines
+122
to
+131
| elif implementation.is_modin(): | ||
| # NOTE: Function moved + deprecated (0.26.0), then old path removed (0.31.0) | ||
| # https://github.com/modin-project/modin/pull/6806 | ||
| # https://github.com/modin-project/modin/pull/7274 | ||
| if implementation._backend_version() >= (0, 26, 0): | ||
| from modin.pandas.io import from_arrow as mpd_from_arrow | ||
| else: # pragma: no cover | ||
| from modin.pandas.utils import ( | ||
| from_arrow as mpd_from_arrow, # pyright: ignore[reportAttributeAccessIssue] | ||
| ) |
Member
Author
There was a problem hiding this comment.
I know ordering the branches the other way would appease coverage
They're this way around so that the known type comes before Unknown
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this? (check all applicable)
Related issues
{DataFrame,Series}.to_pandas#2879DataFrame.from_arrow#2891Checklist
If you have comments or can explain your changes, please do so below
Upstream: